Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes resize when using maximize #13

Merged
merged 1 commit into from
Sep 8, 2017
Merged

fixes resize when using maximize #13

merged 1 commit into from
Sep 8, 2017

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Aug 30, 2017

Before this, if you maximized the window, you would sometimes get a weird bug where the ogre render area was a different size than the Qt window, e.g.:

screenshot from 2017-08-30 15-09-49

(the sphere should be in the center)

@wjwwood wjwwood added the bug Something isn't working label Aug 30, 2017
@wjwwood wjwwood self-assigned this Aug 30, 2017
@wjwwood wjwwood added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Aug 30, 2017
@greimela
Copy link

I still have a bug after this fix (Ubuntu 16.04 + GNOME 3).

When maximising the window the render window adjusts fine.
But after unmaximising the render window does not adjust to fit the smaller window.

bad-resize
(again, the sphere should be in the center)

@wjwwood
Copy link
Member Author

wjwwood commented Aug 31, 2017

@greimela I have the exact same setup, but I wasn't able to get that behavior. Can you confirm that you're using the fix (you recompiled and everything)? I just tried it again and couldn't get it to fail with the patch, though it could just be a fluke.

@anhosi
Copy link
Contributor

anhosi commented Sep 4, 2017

Works on my machine (Ubuntu 16.10 + Fvwm 2.6.5)

@Martin-Idel
Copy link
Contributor

Also works on my machine (Ubuntu 16.04 + Unity)

@greimela
Copy link

greimela commented Sep 5, 2017

Looks like it has something to do with my Ubuntu + Gnome setup.
Let's exclude the problem from this PR for now and I will investigate futher.

@wjwwood
Copy link
Member Author

wjwwood commented Sep 8, 2017

Ok, I'll merge this then. @greimela can you open a new issue so we don't lose track of this?

@wjwwood wjwwood merged commit 24e7f29 into ros2 Sep 8, 2017
@wjwwood wjwwood deleted the fix_resize_on_maximize branch September 8, 2017 01:16
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Sep 8, 2017
@greimela-si
Copy link
Contributor

Done, see #25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants