Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable install of pdb files for ogre, seems broken #12

Merged
merged 2 commits into from
Sep 14, 2017

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Aug 30, 2017

When trying to build for Debug on Windows this caused the ogre install target to fail. I guess it has not been tested in combination with static build.

For now I think we should just disable it. Later, if we need the pdb files for debugging I can try to patch ogre (and make a pr upstream).

@wjwwood wjwwood added the bug Something isn't working label Aug 30, 2017
@wjwwood wjwwood self-assigned this Aug 30, 2017
@wjwwood wjwwood added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Aug 30, 2017
@greimela
Copy link

greimela commented Sep 5, 2017

I can reproduce the problem with the pdb files on Windows.
The PR fixes this and looks fine to me.

@wjwwood wjwwood merged commit f12b6d9 into ros2 Sep 14, 2017
@wjwwood wjwwood deleted the disable_install_pdb_for_rviz_ogre_vendor branch September 14, 2017 01:49
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants