fixup rendering example and resizing #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also refactored the rendering example to just load the ogre window and not have tabs. I had the tabs originally to play with some Qt behaviors, it also delayed loading of the ogre window until I changed tabs which was nice in a few instances, but we don't need that now. |
|
maybe it's time to buy a GTX 1080 ? |
|
... Ti, SLI ... and a gaming monitor. |
I think the window currently renders just one frame per second, not caring about the hardware. |
Perhaps for some other reason that is still the case, but I did remove the QTimer in this pr that fired the render signal periodically once per second. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also removed the timer doing a periodic render and added a renderLater to the resize event, since I noticed that the window would sometimes not get refreshed after a resize, leaving blank bars and stuff.
Fixes #2.
The rendering is pretty laggy too, at least on my work desktop. It's not a slouch either, GTX 1070 and 12-core i7. Not sure what that's about.