Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rviz_rendering] add ament linters #1

Closed
wjwwood opened this issue Aug 29, 2017 · 0 comments · Fixed by #17
Closed

[rviz_rendering] add ament linters #1

wjwwood opened this issue Aug 29, 2017 · 0 comments · Fixed by #17
Labels
enhancement New feature or request

Comments

@wjwwood
Copy link
Member

wjwwood commented Aug 29, 2017

The rviz_rendering package is already setup as an ament package, but we should add the normal ament linters from the ros2 project so we can hae automatic linting and style checking for our cmake and c++ code.
@wjwwood wjwwood added the enhancement New feature or request label Aug 29, 2017
@Martin-Idel Martin-Idel mentioned this issue Aug 31, 2017
Merged
@Martin-Idel-SI Martin-Idel-SI mentioned this issue Oct 18, 2017
Closed
GW1708 pushed a commit to GW1708/rviz that referenced this issue Nov 22, 2018
Code Review ros2#1
1dabf82 
Fixed Minor Things and Refurbished mainly process Message Function.
Split it up in three different functions for easier readability.
Split up also allows to unit test it now because point cloud common
does not have to be initialised
GW1708 pushed a commit to GW1708/rviz that referenced this issue Nov 30, 2018
Code Review ros2#1
eefb04f 
Fixed Minor Things and Refurbished mainly process Message Function.
Split it up in three different functions for easier readability.
Split up also allows to unit test it now because point cloud common
does not have to be initialised
@nbbrooks nbbrooks mentioned this issue Jan 14, 2020
Closed
@hidmic hidmic mentioned this issue Oct 29, 2020
Merged
ahcorde pushed a commit that referenced this issue Jun 11, 2021
@cturcotte-qnx
Merge pull request #1 from cturcotte-qnx/yuv_to_rgb
8f43339 
added yuv to rgb Image conversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Linting for rviz_rendering bosch-io/rviz
1 participant
@wjwwood