Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fault injection macros and test #509

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Add fault injection macros and test #509

merged 2 commits into from
Aug 25, 2020

Conversation

brawner
Copy link
Contributor

@brawner brawner commented Jul 29, 2020

This adds fault injection macros and unit tests to rosidl_runtime_c. Coverage should get to 97% or thereabouts. I'll run CI tests shortly.

Signed-off-by: Stephen Brawner brawner@gmail.com

@brawner
Add fault injection macros and test
0aad666 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner brawner marked this pull request as draft July 29, 2020 01:21
@brawner brawner self-assigned this Jul 29, 2020
@brawner
Copy link
Contributor Author

brawner commented Aug 12, 2020

Builds and tests of the following packages rcutils, rcl_logging_spdlog, rosidl_typesupport_c, rosidl_typesupport_cpp, rcl, rcl_action, rcl_lifecycle, rosidl_runtime_c, rmw_dds_common, rmw

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@brawner
target definitions
43b6e0c 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner brawner force-pushed the brawner/fault-injection-macros branch from 4f17b5b to 43b6e0c Compare August 12, 2020 23:55
@brawner brawner mentioned this pull request Aug 17, 2020
Merged
@brawner brawner marked this pull request as ready for review August 24, 2020 18:52
@brawner
Copy link
Contributor Author

brawner commented Aug 24, 2020

Testing this PR branch against current ros2 branches (not fault injection ones).

Testing --packages-select rosidl_runtime_c

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@brawner brawner requested review from hidmic and Blast545 August 24, 2020 18:58
Blast545
Blast545 approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please check PR job failure before merging

hidmic
hidmic approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@brawner
Copy link
Contributor Author

brawner commented Aug 25, 2020

Similarly to ros2/rcl#727, this PR requires a more up-to-date version of rcutils than the binary release :/ CI jobs I posted above are built with the current ros 2 branches

@brawner brawner merged commit 279731b into master Aug 25, 2020
ahcorde pushed a commit that referenced this pull request Oct 2, 2020
@brawner @ahcorde
Add fault injection macros and test (#509)
dfdfe9c 
* Add fault injection macros and test

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* target definitions

Signed-off-by: Stephen Brawner <brawner@gmail.com>
ahcorde pushed a commit that referenced this pull request Oct 7, 2020
@brawner @ahcorde
Add fault injection macros and test (#509)
b0d8725 
* Add fault injection macros and test

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* target definitions

Signed-off-by: Stephen Brawner <brawner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

@Blast545 Blast545 Blast545 approved these changes

Assignees

@brawner brawner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brawner @Blast545 @hidmic