Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to not register the generated interfaces as a rosidl_interfaces ament resource #454

Closed
wants to merge 1 commit into from
Closed

Add a way to not register the generated interfaces as a rosidl_interfaces ament resource #454

wants to merge 1 commit into from

Conversation

ivanpauno
Copy link
Member

@ivanpauno ivanpauno commented Apr 6, 2020 •
edited
Loading

@ivanpauno
Add a way to not register the generated interfaces as a rosidl_interf…
41acd5b 
…aces ament resource

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno mentioned this pull request Apr 6, 2020
Closed
@ivanpauno ivanpauno self-assigned this Apr 6, 2020
@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label Apr 6, 2020
@ivanpauno ivanpauno requested a review from dirk-thomas April 6, 2020 16:05
@ivanpauno ivanpauno mentioned this pull request Apr 6, 2020
Closed
dirk-thomas
dirk-thomas suggested changes Apr 6, 2020
View reviewed changes
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without a clear rational why this is absolutely necessary we shouldn't introduce / use this option.

@dirk-thomas
Copy link
Member

Closing in favor of ros2/rosidl_typesupport#50 (comment)

@dirk-thomas dirk-thomas closed this Apr 9, 2020
@dirk-thomas dirk-thomas deleted the ivanpauno/fix-ros1-bridge branch April 9, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas requested changes

Assignees

@ivanpauno ivanpauno

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanpauno @dirk-thomas