Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[humble] Add recorder stop() API (backport #1300) #1396

Merged
merged 1 commit into from
Jun 13, 2023
Merged

[humble] Add recorder stop() API (backport #1300) #1396

merged 1 commit into from
Jun 13, 2023

Conversation

MichaelOrlov
Copy link
Contributor

@MichaelOrlov MichaelOrlov commented Jun 13, 2023 •
edited
Loading

@morlov-apexai
Add recorder stop() API (backport #1300)
4e429d8 
- Add Recorder::stop() API
- Move routines from recorder's destructor to RecorderImpl::stop()
- Add can_record_again_after_stop unit test in rosbag2_transport
- Update Doxygen comments for stop() and pause() API in recorder.hpp

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov MichaelOrlov force-pushed the morlov/backport_recorder_stop_to_humble branch from 02438aa to 4e429d8 Compare June 13, 2023 07:22
@MichaelOrlov MichaelOrlov self-assigned this Jun 13, 2023
@MichaelOrlov MichaelOrlov added the humble Humble Hawksbill label Jun 13, 2023
@MichaelOrlov
Copy link
Contributor Author

Gist: https://gist.githubusercontent.com/MichaelOrlov/985f7d2d3934588c7e6b3c359e32b6c6/raw/571985b79a6b78718f87c1b61515f72b470aa4e6/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_transport rosbag2_cpp
TEST args: --packages-above rosbag2_transport rosbag2_cpp
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12219

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov MichaelOrlov marked this pull request as ready for review June 13, 2023 07:30
@MichaelOrlov MichaelOrlov requested a review from a team as a code owner June 13, 2023 07:30
@MichaelOrlov MichaelOrlov requested review from gbiggs and removed request for a team June 13, 2023 07:30
This was referenced Jun 13, 2023
Merged
Merged
@emersonknapp emersonknapp merged commit e4604c5 into humble Jun 13, 2023
@delete-merged-branch delete-merged-branch bot deleted the morlov/backport_recorder_stop_to_humble branch June 13, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner automatically assigned from ros2/tooling-reviewers

Assignees

@MichaelOrlov MichaelOrlov

Labels
humble Humble Hawksbill
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelOrlov @emersonknapp @morlov-apexai