-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[humble] When using sim time, wait for /clock before beginning recording (backport #1378) #1392
Conversation
* When using sim time, wait for /clock before beginning recording * Disable use-sim-time && no-discovery combo, allow re-enabling discovery after stop() Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> (cherry picked from commit d52ddbb) # Conflicts: # ros2bag/ros2bag/verb/record.py # rosbag2_transport/src/rosbag2_transport/recorder.cpp
9d6c515
to
cb7b4da
Compare
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
cb7b4da
to
515df43
Compare
@ros-pull-request-builder retest this please |
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Requires ros2/rclcpp#2040 - discussing on the issue whether we can backport it to Humble. If not, I can do an "inline cherry-pick" of the needed functions into |
…p as proposal. Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
5f4ab86
to
940c12c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport LGTM among one nitpick with missed timeout
parameter.
…, just up as proposal." This reverts commit 940c12c. Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Backports created ros2/rcl#1078, ros2/rclcpp#2210 and approved, running CI. I will wait on those instead of copying the code here |
Pulls: #1392 |
Depends on ros2/rcl#1078
Depends on ros2/rclcpp#2210
This is an automatic backport of pull request #1378 done by Mergify.
Cherry-pick of d52ddbb has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com