Add config and launch directories to recommended package layout #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two directories seem common enough, and already a convention, that we should consider adding them to the recommended package layout. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
Other common directories are "scripts", "bin", and "env_hook", though I'm not sure if we want to recommend anything about those. |
I would 👎 |
clalancette
approved these changes
Feb 25, 2021
|
@Mergifyio backport rolling |
mergify bot
pushed a commit
that referenced
this pull request
Feb 25, 2021
These two directories seem common enough, and already a convention, that we should consider adding them to the recommended package layout. Signed-off-by: Jacob Perron <jacob@openrobotics.org> (cherry picked from commit 5eb270f)
|
Command
|
mergify bot
added a commit
that referenced
this pull request
Feb 25, 2021
… (#1144) These two directories seem common enough, and already a convention, that we should consider adding them to the recommended package layout. Signed-off-by: Jacob Perron <jacob@openrobotics.org> (cherry picked from commit 5eb270f) Co-authored-by: Jacob Perron <jacob@openrobotics.org> (cherry picked from commit 01fdf6e)
mergify bot
added a commit
that referenced
this pull request
Feb 25, 2021
… (#1144) These two directories seem common enough, and already a convention, that we should consider adding them to the recommended package layout. Signed-off-by: Jacob Perron <jacob@openrobotics.org> (cherry picked from commit 5eb270f) Co-authored-by: Jacob Perron <jacob@openrobotics.org> (cherry picked from commit 01fdf6e)
clalancette
pushed a commit
that referenced
this pull request
Feb 25, 2021
… (#1144) (#1145) These two directories seem common enough, and already a convention, that we should consider adding them to the recommended package layout. Signed-off-by: Jacob Perron <jacob@openrobotics.org> (cherry picked from commit 5eb270f) Co-authored-by: Jacob Perron <jacob@openrobotics.org> (cherry picked from commit 01fdf6e) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
clalancette
pushed a commit
that referenced
this pull request
Feb 25, 2021
… (#1144) (#1146) These two directories seem common enough, and already a convention, that we should consider adding them to the recommended package layout. Signed-off-by: Jacob Perron <jacob@openrobotics.org> (cherry picked from commit 5eb270f) Co-authored-by: Jacob Perron <jacob@openrobotics.org> (cherry picked from commit 01fdf6e) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two directories seem common enough, and already a convention,
that we should consider adding them to the recommended package layout.
Pinging @ros2/team in case there are any objections.