Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter issues #200

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Fix linter issues #200

merged 1 commit into from
Nov 23, 2021

Conversation

Blast545
Copy link
Contributor

@Blast545 Blast545 commented Nov 23, 2021 •
edited
Loading

Signed-off-by: Jorge Perez jjperez@ekumenlabs.com

Small PR, should fix linter issues introduced with #196

CI testing test_rmw_implementation before PR:

  • Linux Build Status

CI after PR:

  • Linux Build Status

(Checking full CI after linux CI passes)

@Blast545
Fix linter issues
c6cc3ad 
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 self-assigned this Nov 23, 2021
@Blast545 Blast545 added the tests Failing or missing tests label Nov 23, 2021
@Blast545 Blast545 requested a review from ivanpauno November 23, 2021 20:29
@Blast545
Copy link
Contributor Author

OK, ready for review:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

ivanpauno
ivanpauno approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I don't know why this wasn't catched in the original CI jobs

@Blast545
Copy link
Contributor Author

@ivanpauno No prob, thanks for your review!

I don't know why this wasn't catched in the original CI jobs

It didn't include test_rmw_implementation package and the linter issues were specifically there.

@Blast545 Blast545 merged commit 567e922 into master Nov 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the blast545/fix_196_linters branch November 23, 2021 21:36
@aprotyas aprotyas mentioned this pull request Nov 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees

@Blast545 Blast545

Labels
tests Failing or missing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Blast545 @ivanpauno