Avoid memory leak; setName makes its own copy of the string.

ros2 · Apr 1, 2016 · 8e501cd · 8e501cd
1 parent b19a0b4
commit 8e501cd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/rmw_fastrtps_cpp/src/MessageTypeSupport.cpp b/rmw_fastrtps_cpp/src/MessageTypeSupport.cpp
@@ -18,7 +18,7 @@ MessageTypeSupport::MessageTypeSupport(const rosidl_typesupport_introspection_cp
         typeTooLarge_ = true;
 
     std::string name = std::string(members->package_name_) + "::msg::dds_::" + members->message_name_ + "_";
-    setName(strdup(name.c_str()));
+    setName(name.c_str());
 
     if(members->member_count_ != 0)
         m_typeSize = calculateMaxSerializedSize(members, 0);

diff --git a/rmw_fastrtps_cpp/src/functions.cpp b/rmw_fastrtps_cpp/src/functions.cpp
@@ -300,6 +300,7 @@ extern "C"
             static_cast<const char *>(malloc(sizeof(char) * strlen(name) + 1));
         if (!node_handle->name) {
             RMW_SET_ERROR_MSG("failed to allocate memory");
+            free(node_handle);
             return NULL;
         }
         memcpy(const_cast<char *>(node_handle->name), name, strlen(name) + 1);