Small performance improvments

Address small performance issues to ROS2 impacting the `rmw_count_publishers` and `rmw_count_subscribers` method when called with a significante number of topics to count.
The root of the performance issues come from the duplication of `std::string` type of objects. These duplication are honerous with strings and cause a significante amount of CPU cycle to be wasted duplicating things.

rmw_fastrtps_cpp/src/demangle.cpp

@@ -25,11 +25,7 @@
 std::string
 _demangle_if_ros_topic(const std::string & topic_name)
 {
-  std::string prefix = _get_ros_prefix_if_exists(topic_name);
-  if (prefix.length()) {
-    return topic_name.substr(strlen(ros_topic_prefix));
-  }
-  return topic_name;
+  return _strip_ros_prefix_if_exists(topic_name);
 }
 
 /// Return the demangled ROS type or the original if not a ROS type.

rmw_fastrtps_cpp/src/namespace_prefix.cpp

@@ -29,13 +29,25 @@ const std::vector<std::string> _ros_prefixes =
 }  // extern "C"
 
 /// Return the ROS specific prefix if it exists, otherwise "".
-std::string
+const std::string
 _get_ros_prefix_if_exists(const std::string & topic_name)
 {
-  for (auto prefix : _ros_prefixes) {
-    if (topic_name.rfind(std::string(prefix) + "/", 0) == 0) {
+  for (auto const &prefix : _ros_prefixes) {
+    if ((topic_name.rfind(prefix, 0) == 0) && (topic_name.at(prefix.length()) == '/')) {
       return prefix;
     }
   }
   return "";
 }
+
+/// Strip the ROS specific prefix if it exists from the topic name.
+const std::string
+_strip_ros_prefix_if_exists(const std::string & topic_name)
+{
+  for (auto const &prefix : _ros_prefixes) {
+    if ((topic_name.rfind(prefix, 0) == 0) && (topic_name.at(prefix.length()) == '/')) {
+      return topic_name.substr(prefix.length());
+    }
+  }
+  return topic_name;
+}

rmw_fastrtps_cpp/src/namespace_prefix.hpp

@@ -28,7 +28,10 @@ extern const std::vector<std::string> _ros_prefixes;
 }  // extern "C"
 
 /// Return the ROS specific prefix if it exists, otherwise "".
-std::string
+const std::string
 _get_ros_prefix_if_exists(const std::string & topic_name);
 
+/// Returns the topic name stripped of and ROS specific prefix if exists.
+const std::string
+_strip_ros_prefix_if_exists(const std::string & topic_name);
 #endif  // NAMESPACE_PREFIX_HPP_

rmw_fastrtps_cpp/src/rmw_count.cpp

@@ -51,8 +51,8 @@ rmw_count_publishers(
   WriterInfo * slave_target = impl->secondaryPubListener;
   slave_target->mapmutex.lock();
   *count = 0;
-  for (auto it : slave_target->topicNtypes) {
-    auto topic_fqdn = _demangle_if_ros_topic(it.first);
+  for (auto const &it : slave_target->topicNtypes) {
+    auto const topic_fqdn = _demangle_if_ros_topic(it.first);
     if (topic_fqdn == topic_name) {
       *count += it.second.size();
     }
@@ -90,8 +90,8 @@ rmw_count_subscribers(
   ReaderInfo * slave_target = impl->secondarySubListener;
   *count = 0;
   slave_target->mapmutex.lock();
-  for (auto it : slave_target->topicNtypes) {
-    auto topic_fqdn = _demangle_if_ros_topic(it.first);
+  for (auto const & it : slave_target->topicNtypes) {
+    auto const topic_fqdn = _demangle_if_ros_topic(it.first);
     if (topic_fqdn == topic_name) {
       *count += it.second.size();
     }