This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Update gid API return codes. #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
CI up to
|
clalancette
reviewed
Sep 22, 2020
Comment on lines
-51
to
-54
| if (!detail1) { | ||
| RMW_SET_ERROR_MSG("gid1 is invalid"); | ||
| return RMW_RET_ERROR; | ||
| } |
There was a problem hiding this comment.
So can it be the case that gid1->data is nullptr? Or are we just taking the approach of elsewhere where nullptr is just a special case of "undefined pointer"?
There was a problem hiding this comment.
gid1->data won't ever be nullptr -- it's a primitive array.
clalancette
approved these changes
Sep 22, 2020
ahcorde
pushed a commit
that referenced
this pull request
Oct 9, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde
pushed a commit
that referenced
this pull request
Oct 15, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be compliant with the API spec. Connected to ros2/rmw#274.