-
Notifications
You must be signed in to change notification settings - Fork 33
Conversation
I'm putting this one up for review as well. Some notes:
Related tests in Both of these issues are related to the fact that Connext doesn't notify on local creation of DataWriter's and DataReader's, see: ros2/ros2#215 (comment) I still think we should review and merge this as-is for two reasons: it is incrementally better and does work for different participants, and without the functions at least implemented rcl won't link. After merging I'll create issues on this repository to track the remaining issues. |
|
||
ROSIDL_TYPESUPPORT_CONNEXT_CPP_PUBLIC | ||
const char * | ||
get_request_topic_name__@(spec.srv_name)(void * untyped_requester); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change does not appear in the parallel change is that expected? https://github.com/ros2/rmw_opensplice/pull/137/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is expected, because in OpenSplice the "requester" object is available and I can just call get_topic_name
(or something like that) on it. In Connext, the requester object is type erased, so I have to ask the generated code to cast it to the right type and then call that function on it.
lgtm |
Connects to ros2/ros2#215
I'm currently dealing with an issue where the locally created DataReaders and DataWriters do not notify our listener: https://community.rti.com/forum-topic/built-publication-data-local-datawriters-and-datareaders