Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support node namespaces #95

Merged
merged 10 commits into from
Apr 8, 2017
Merged

Support node namespaces #95

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
621753e
add rmw_validate_node_name()
wjwwood Mar 29, 2017
90cea5a
add name_space to the node
wjwwood Mar 29, 2017
0ebcc3e
name_space -> namespace_
wjwwood Mar 30, 2017
b6f79db
fix docs
wjwwood Apr 6, 2017
e1eb636
fix doc typo
wjwwood Apr 6, 2017
383db0f
add rmw_validate_namespace()
wjwwood Apr 6, 2017
833c760
make invalid_index optional (can pass NULL)
wjwwood Apr 7, 2017
2421302
include the validation result value when it is unknown
wjwwood Apr 7, 2017
6520d6f
use _snprintf_s on windows
wjwwood Apr 8, 2017
d4fb6d3
uncrustify
wjwwood Apr 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rmw/include/rmw/rmw.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ rmw_init(void);
RMW_PUBLIC
RMW_WARN_UNUSED
rmw_node_t *
rmw_create_node(const char * name, size_t domain_id);
rmw_create_node(const char * name, const char * namespace_, size_t domain_id);

RMW_PUBLIC
RMW_WARN_UNUSED
Expand Down
1 change: 1 addition & 0 deletions rmw/include/rmw/types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ typedef struct RMW_PUBLIC_TYPE rmw_node_t
const char * implementation_identifier;
void * data;
const char * name;
const char * namespace_;
const size_t domain_id;
} rmw_node_t;

Expand Down
2 changes: 1 addition & 1 deletion rmw/include/rmw/validate_node_name.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ extern "C"
*
* - must not be an empty string
* - must only contain alphanumeric characters and underscores (a-z|A-Z|0-9|_)
* - must not start with an number
* - must start with an alphabetical character
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I missed the discussion in another thread. Why do we want to prohibit node name starting with an underscore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I was just trying to simplify the rules, but I forgot about the underscores. The implementation didn't actually change. I'll switch it back b6f79db.

*
* If either the node name C string or validation_result pointer are null, then
* `RMW_RET_INVALID_ARGUMENT` will be returned.
Expand Down