Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added rmw_security_common #388

Merged
merged 6 commits into from
Feb 14, 2025
Merged

Added rmw_security_common #388

merged 6 commits into from
Feb 14, 2025

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jan 29, 2025 •
edited
Loading

Replace ros2/sros2#330

the new rmw_zenoh_cpp has an open PR to include certificates using the --enclave argument. This requires to use rmw_dds_common::get_security_files which is not a dds unique utility.

The idea with new package is to include here all the security common things.

As discussed in the ROS weekly meeting, we decided to include this package under the rmw repository and it should use C in the signature as the other rmw functions.

Related PRs

Deprecated current implementation in rmw_dds_common

@ahcorde
Added rmw_security_common
d2b0798 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from clalancette January 29, 2025 11:28
@ahcorde ahcorde self-assigned this Jan 29, 2025
@ahcorde ahcorde mentioned this pull request Jan 29, 2025
Closed
@ahcorde
Removed warnings
53e5609 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde mentioned this pull request Jan 29, 2025
Open
This was referenced Jan 30, 2025
Merged
Merged
Merged
@ahcorde
feedback
f59454c 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
feedback
54c05da 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from fujitatomoya February 11, 2025 12:54
fujitatomoya
fujitatomoya approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 12, 2025

Pulls: #388, ros2/rmw_cyclonedds#529, ros2/rmw_fastrtps#803, ros2/rmw_connextdds#167, ros2/rmw_dds_common#77
Gist: https://gist.githubusercontent.com/ahcorde/c0bfb74dcaed3942f416c34a9b490f47/raw/714c3d891f007436c263bc7963598ef6a05054d9/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_security_common rmw_dds_common rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_connextdds --packages-above-and-dependencies rmw_security_common rmw_dds_common rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_connextdds --cmake-args -DSECURITY=ON
TEST args: --packages-above rmw_security_common rmw_dds_common rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_connextdds --packages-above rmw_security_common rmw_dds_common rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_connextdds
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15176

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde mentioned this pull request Feb 12, 2025
Merged
@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 12, 2025

Pulls: #388, ros2/rmw_cyclonedds#529, ros2/rmw_fastrtps#803, ros2/rmw_connextdds#167, ros2/rmw_dds_common#77
Gist: https://gist.githubusercontent.com/ahcorde/5b78efa6d3ca4e7fdb4dd2e3fca2fe72/raw/714c3d891f007436c263bc7963598ef6a05054d9/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_security_common rmw_dds_common rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_connextdds_common --packages-above-and-dependencies rmw_security_common rmw_dds_common rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_connextdds_common --cmake-args -DSECURITY=ON
TEST args: --packages-above rmw_security_common rmw_dds_common rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_connextdds_common --packages-above rmw_security_common rmw_dds_common rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_connextdds_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15177

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 12, 2025

Pulls: #388, ros2/rmw_cyclonedds#529, ros2/rmw_fastrtps#803, ros2/rmw_connextdds#167, ros2/rmw_dds_common#77
Gist: https://gist.githubusercontent.com/ahcorde/21ab5b7ad3122eb4c98d300a252b2754/raw/714c3d891f007436c263bc7963598ef6a05054d9/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_security_common --packages-above-and-dependencies rmw_security_common --cmake-args -DSECURITY=ON
TEST args: --packages-above rmw_security_common --packages-above rmw_security_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15178

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 12, 2025

Pulls: #388, ros2/rmw_cyclonedds#529, ros2/rmw_fastrtps#803, ros2/rmw_connextdds#167, ros2/rmw_dds_common#77
Gist: https://gist.githubusercontent.com/ahcorde/2568a2beac974257b33e414c23d331ed/raw/714c3d891f007436c263bc7963598ef6a05054d9/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_security_common --cmake-args -DSECURITY=ON
TEST args: --packages-above rmw_security_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15183

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 12, 2025

Pulls: #388, ros2/rmw_cyclonedds#529, ros2/rmw_fastrtps#803, ros2/rmw_connextdds#167, ros2/rmw_dds_common#77
Gist: https://gist.githubusercontent.com/ahcorde/e86ea6f6c25a1fe0b28a6d6af0a35daf/raw/714c3d891f007436c263bc7963598ef6a05054d9/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_security_common --cmake-args -DSECURITY=ON
TEST args: --packages-above rmw_security_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15184

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 13, 2025 •
edited
Loading

Pulls: #388, ros2/rmw_cyclonedds#529, ros2/rmw_fastrtps#803, ros2/rmw_connextdds#167, ros2/rmw_dds_common#77
Gist: https://gist.githubusercontent.com/ahcorde/f529df4f2761b821f1de877299fbd650/raw/714c3d891f007436c263bc7963598ef6a05054d9/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_security_common rmw_dds_common rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_connextdds_common --cmake-args -DSECURITY=ON
TEST args: --packages-above rmw_security_common rmw_dds_common rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_connextdds_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15185

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Increase CMake version
4f4fb2f 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 13, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit b3dbdad into rolling Feb 14, 2025
2 of 3 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/rmw_security_common branch February 14, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz left review comments

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@clalancette clalancette Awaiting requested review from clalancette

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @sloretz @fujitatomoya