Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace expansion #104

Merged
merged 3 commits into from
May 9, 2017
Merged

Namespace expansion #104

merged 3 commits into from
May 9, 2017

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Apr 25, 2017 •
edited
Loading

This renames rmw_validate_topic_name() to rmw_validate_full_topic_name() as so to differentiate it from the new rcl_validate_topic_name() which validates non-fully qualified topic names, whereas the function in the repository does operate on fully qualified topic names.

It also removes isalnum_no_locale() from this package to use the version in rcutils which is newly added in ros2/rcutils#20.

Connects to ros2/rcl#132

@wjwwood wjwwood added the in progress Actively being worked on (Kanban column) label Apr 25, 2017
@wjwwood wjwwood self-assigned this Apr 25, 2017
@wjwwood wjwwood added enhancement New feature or request in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Apr 27, 2017
@wjwwood wjwwood merged commit b69dfb9 into master May 9, 2017
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label May 9, 2017
@wjwwood wjwwood deleted the namespace_expansion branch May 9, 2017 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karsten1987 Karsten1987 Karsten1987 approved these changes

Assignees

@wjwwood wjwwood

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjwwood @Karsten1987