Fail on invalid and unknown ROS specific arguments #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should probably discuss the implications of having exceptions defined in the C extensions vs. Python sources. |
ivanpauno
reviewed
Sep 4, 2019
There was a problem hiding this comment.
Some minor comments. Also, check the result of this discussion before merging:
#413 (comment)
57a94cd to
9f70bd9
Compare
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
9f70bd9 to
1fc0683
Compare
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ivanpauno
reviewed
Sep 5, 2019
ivanpauno
approved these changes
Sep 5, 2019
|
@ivanpauno it's here. Only reasonable explanation is that I thought I re-ran it after addressing your comments but I didn't. I'll fix it, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precisely what the title says. This pull request makes
rclpyraise if either an invalid or an unknown ROS argument is found.