added wait method to AsyncParametersClient #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@BrannonKing FYI |
|
I fixed the usage of the visibility macros in 16be382
|
|
The visibility macros set the attributes for dllexport / dllimport depending if the function is being built at compile time of the package or later being used from other code through the header declaration. Since the templated function are header only and are only expanded when actually being used they never end up in the built library of the package containing the declaration and therefore don't need the attributes. |
69165ee to
967a3eb
Compare
967a3eb to
a51d585
Compare
|
@ros2/team Waiting for review. |
wjwwood
approved these changes
Jul 10, 2017
|
Thanks. |
BrannonKing
added a commit
to asirobots/rclcpp
that referenced
this pull request
Jul 10, 2017
added wait method to AsyncParametersClient (ros2#342)
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
* rcl_action_expire_goals() outputs goals that expire
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* add filter for selecting topics to read Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * add StorageFilter Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * add safety check for storage pointer; add reset_filter Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * add set_filter and reset_filter to Reader Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * fix mock sequential reader for rosbag2_transport test Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * add topic filter to transport play options Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * add selective topics to cmd line Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * fix cpplint Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * end to end read test Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * fix cmd line args Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * add play end to end test for filter topic Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * remove read test Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * remove read test in CMakeList Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * fix flake8 Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * address PR comments Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * revert rosbag2_cpp Reader Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * unrevert rosbag2_cpp Reader Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * address PR comments Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * vector initialization Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * remove line break Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * fix merge errors Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * style Signed-off-by: Mabel Zhang <mabel@openrobotics.org> * alpha order Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #337.