Add LifecycleSubscription #2715
Conversation
dce2aa1 to
113024c
Compare
| { | ||
| } | ||
|
|
||
| /// TODO: Hold onto the data that arrives before activation, and deliver that on activation. |
There was a problem hiding this comment.
besides this, i think subscription should not be discovered in the graph if that is in unconfigure state. if that comes to inactive state (means it is configured), subscription will be discovered in the ROS 2 network. and then hold onto the data in the rmw message queue not to take them out and dispose as described here.
for doing that, probably we need to have state control (configured, inactive) in SubscriberBase class and underlying implementations, and then on_configure callback, we can configure the subscription to be discovered. (on_activate, it can take the data out of the queue.) i am not sure how exactly we want to design this at this moment, but we would want to add some comments here too. (this feature is similar with LazySubscription concept.)
note that this requirement should also go to LifecyclePublisher as well.
what do you think?
There was a problem hiding this comment.
This does sound good to me. 👍
Is this something that has to be done in this PR or can a future PR be made instead? I will add a TODO if the latter is the case.
| } | ||
| } | ||
|
|
||
| void empty_callback(const test_msgs::msg::Empty msg) {} |
There was a problem hiding this comment.
i think one of the most important test case is missing here.
inactivestate callback should not be called. if called, asserts the test.activestate, callback should be called. if not called, asserts the test.
113024c to
adaf96c
Compare
Co-authored-by: Adam Milner <milner@elroyair.com> Signed-off-by: Aarav Gupta <amronos275@gmail.com>
adaf96c to
8ab376b
Compare
This PR uses most of the changes made in #2254, fixes some of the issues in that PR, and adds a test.