Change behavior of timer on construction #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm working on getting #140 merged today, can we defer this fix until then? |
|
+1 |
|
Sure. I'll run tests with this branch to check its correctness but I won't On Thu, Nov 5, 2015 at 2:09 PM, William Woodall notifications@github.com
|
|
It looks good to me too. |
|
+1 |
1 similar comment
|
+1 |
0f23a16 to
dcd5117
Compare
jacquelinekay
added a commit
that referenced
this pull request
Nov 6, 2015
Change behavior of timer on construction
|
This appears to have caused a regression in test_rclcpp: http://ci.ros2.org/job/ros2_batch_ci_linux/567/testReport/ I'll follow up with a fix. |
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
mauropasse
pushed a commit
to mauropasse/rclcpp
that referenced
this pull request
Aug 6, 2024
* add logs and minor fixes Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com> * use >0 rather than ==1 in comparison Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com> --------- Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
mauropasse
pushed a commit
to mauropasse/rclcpp
that referenced
this pull request
Aug 8, 2024
* add logs and minor fixes Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com> * use >0 rather than ==1 in comparison Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com> --------- Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ros2/system_tests#36
Based on the discussion in ros2/system_tests#66
Previously, timers would fire on the very first call to spin, no matter how much time passed between their construction and the call to spin.
This PR will change the behavior of timers so that the timer will fire one period after being created, or on the first call to spin IF that call happens after one period.