Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rclcpp_action] Progress Toward Quality Level 1 #1036

Closed
19 tasks done
brawner opened this issue Mar 30, 2020 · 2 comments
Closed
19 tasks done

[rclcpp_action] Progress Toward Quality Level 1 #1036

brawner opened this issue Mar 30, 2020 · 2 comments

Comments

@brawner
Copy link
Contributor

brawner commented Mar 30, 2020 •
edited by chapulina
Loading

This issue tracks the progression of rclcpp_action to Quality Level 1 and a 1.0 version level. It follows the outline described in REP 2004.

  • Version Policy
    • Follows ROS Core Quality Declaration
  • Version >= 1.0.0
  • Change Control Process
    • Follows ROS Core
  • PRs automatically tested on Jenkins

Documentation

  • Per-feature documentation.
  • Per-item documentation in public API.
    • Doxygen documentation is being generated per release, but the API needs further documentation
  • Declared set of licenses
  • Copyright statement in each source file
  • Quality Declaration document

Testing:

Dependencies:

  • Runtime "ROS" dependencies are level 1
    • action_msgs
    • rclcpp
    • rcl_action

Platform Support

  • Supports all tier 1 platforms

Security

  • Vulnerability Disclosure Policy
@chapulina chapulina mentioned this issue Apr 2, 2020
Merged
@chapulina chapulina mentioned this issue Jun 18, 2020
Closed
@ahcorde
Copy link
Contributor

ahcorde commented Jun 25, 2020

Bump QD to level 3 and fixed some links #1158

@chapulina chapulina mentioned this issue Nov 9, 2020
Merged
@chapulina
Copy link
Contributor

Reached level 1! 🎉 #1477

DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this issue Aug 5, 2022
@kylemarcey
Merge "Add additional mode of publishing sim time updates (ros2#1036)…
a3b461c 
…" to rolling (ros2#1050)

* Add new PlayOptions to control new method of /clock publishing

Signed-off-by: Kyle Marcey <kyle.marcey@apex.ai>

* Add new arguments to ros2bag frontend to support publishing /clock updates triggered by replayed messages

Signed-off-by: Kyle Marcey <kyle.marcey@apex.ai>

* Refactor rosbag2_transport::Player to allow two modes of publishing /clock updates.

An additional mode of operation has been added to the Player class to allow for /clock updates. When this mode is active, /clock updates are triggered whenever messages are replayed rather than at a fixed rate. Optionally, a list of triggering topics can be set so that only a subset of replayed messages will trigger the /clock update.

This mode is most useful when replaying applications which do some sanity checking or correlation of message data to system timestamps. If the application does not need the sim time to be updated at a consistent rate, this mode can substantially reduce the overhead of having sim time enabled in rosbag2.

Signed-off-by: Kyle Marcey <kyle.marcey@apex.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brawner @ahcorde @chapulina