Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov to ignore unit tests and rclc_examples package #155

Merged
merged 11 commits into from
Jul 28, 2021

Conversation

JanStaschulat
Copy link
Contributor

@JanStaschulat JanStaschulat commented Jul 21, 2021

test folders should be ignored in the codecov analysis.

root file path in codecov contains a random number, this needs to be fixed. See:
https://docs.codecov.com/docs/fixing-paths

Answer from codecov team: (2021-07-28):

This isn't working because the path of your files is /ros_ws/src/28ud84ktfbl/rclc, if you check that link you shared. You will nead a path fix rule to ajust this so the patch matches your repo https://docs.codecov.com/docs/fixing-paths, or add that prefix to your ignore rules.

Ticket: https://codecov.freshdesk.com/helpdesk/tickets/5626

Best,

Joe Becher (she/her)
Lead Support Engineer | Codecov

Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2021

Codecov Report

Merging #155 (004ab3a) into master (8e8a2d9) will increase coverage by 28.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #155       +/-   ##
===========================================
+ Coverage   31.31%   59.32%   +28.01%     
===========================================
  Files         160       13      -147     
  Lines       19720     1399    -18321     
  Branches     9875      430     -9445     
===========================================
- Hits         6175      830     -5345     
+ Misses       5160      362     -4798     
+ Partials     8385      207     -8178     
Impacted Files Coverage Δ
...s_ws/src/je5tcwrnpue/rclc/rclc/src/rclc/executor.c
...rc/alu0oqea19/rclc/rclc/test/rclc/test_service.cpp
...rc/alu0oqea19/rclc/rclc/src/rclc/executor_handle.c
ros_ws/src/f3ezo7zes9f/rclc/rclc/src/rclc/sleep.c
...oqea19/rclc/rclc_lifecycle/test/test_lifecycle.cpp
...os_ws/src/1k7ce2609y/rclc/rclc/src/rclc/executor.c
ros_ws/src/1k7ce2609y/rclc/rclc/src/rclc/client.c
..._ws/src/f3ezo7zes9f/rclc/rclc/src/rclc/publisher.c
...c_parameter/test/rclc_parameter/test_parameter.cpp
..._ws/src/l8mkmc8zstm/rclc/rclc/src/rclc/publisher.c
... and 163 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e8a2d9...004ab3a. Read the comment docs.

Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat
Copy link
Contributor Author

@mergify backport galactic foxy

@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2021

Command backport galactic foxy: pending

Waiting for the pull request to get merged

Hey, I reacted but my real name is @Mergifyio

Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat
Copy link
Contributor Author

@norro the rclc_lifecycle does not have a subfolder test/rclc_lifecycle as in rclc and rclc_parameter. You might want to fix this when you have time. This required a different rule to ignore the test files for this package: rclc_lifecycle/test/*instead of test/**/*:

ignore:
  - "rclc/test/**/*"
  - "rclc_examples/**/*"
  - "rclc_lifecycle/test/*"
  - "rclc_parameter/test/**/*"

Let me know, when you have fixed it, then I'll update the codecov file. But we can also live with the current package folder structure.

@JanStaschulat JanStaschulat requested a review from pablogs9 July 28, 2021 09:19
@JanStaschulat
Copy link
Contributor Author

@pablogs9 @ralph-lange @norro With this fix, the code coverage of rclc repository increased to 59% (from 31% where test and rclc_examples folders were included).

@JanStaschulat JanStaschulat changed the title test codecov Fix codecov to ignore unit tests and rclc_examples package Jul 28, 2021
@JanStaschulat JanStaschulat merged commit 359c265 into master Jul 28, 2021
@JanStaschulat JanStaschulat deleted the feature/test-codecov branch July 28, 2021 10:05
mergify bot pushed a commit that referenced this pull request Jul 28, 2021
mergify bot pushed a commit that referenced this pull request Jul 28, 2021
(cherry picked from commit 359c265)

# Conflicts:
#	codecov.yml
@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2021

Command backport galactic foxy: success

Backports have been created

JanStaschulat added a commit that referenced this pull request Jul 28, 2021
(cherry picked from commit 359c265)

Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com>
JanStaschulat added a commit that referenced this pull request Jul 28, 2021
…155) (#162)

* Fix codecov to ignore unit tests and rclc_examples package (#155)

(cherry picked from commit 359c265)

# Conflicts:
#	codecov.yml

* resolved merge conflict - removed rclc_parameters

Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>

Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants