-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix codecov to ignore unit tests and rclc_examples package #155
Conversation
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@mergify backport galactic foxy |
Command
Hey, I reacted but my real name is @Mergifyio |
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@norro the
Let me know, when you have fixed it, then I'll update the codecov file. But we can also live with the current package folder structure. |
@pablogs9 @ralph-lange @norro With this fix, the code coverage of rclc repository increased to 59% (from 31% where |
(cherry picked from commit 359c265)
(cherry picked from commit 359c265) # Conflicts: # codecov.yml
Command
|
…155) (#162) * Fix codecov to ignore unit tests and rclc_examples package (#155) (cherry picked from commit 359c265) # Conflicts: # codecov.yml * resolved merge conflict - removed rclc_parameters Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com>
test folders should be ignored in the codecov analysis.
root file path in codecov contains a random number, this needs to be fixed. See:
https://docs.codecov.com/docs/fixing-paths
Answer from codecov team: (2021-07-28):
This isn't working because the path of your files is
/ros_ws/src/28ud84ktfbl/rclc
, if you check that link you shared. You will nead a path fix rule to ajust this so the patch matches your repo https://docs.codecov.com/docs/fixing-paths, or add that prefix to your ignore rules.Ticket: https://codecov.freshdesk.com/helpdesk/tickets/5626
Best,
Joe Becher (she/her)
Lead Support Engineer | Codecov