Add message fixture for DynamicArrayStaticArrayPrimitivesNested #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warnings are from flake8, fixed by ros2/rmw_connext#305. |
clalancette
approved these changes
Oct 26, 2018
| std::vector<test_msgs::msg::StaticArrayPrimitives::SharedPtr> primitive_msgs = | ||
| get_messages_static_array_primitives(); | ||
| for (size_t i = 0; i < primitive_msgs.size(); ++i) | ||
| { |
There was a problem hiding this comment.
I'm somewhat surprised the linters didn't pick this up, but our usual style is curly braces on the same line as the for statement.
There was a problem hiding this comment.
There were no lint tests enabled for this package. I've enabled the linter and fixed issues.
|
👍 |
|
dirk-thomas
pushed a commit
to ros2/test_interface_files
that referenced
this pull request
Jan 18, 2019
…/rcl_interfaces#45) * Add message fixture for test_msgs/DynamicArrayStaticArrayPrimitivesNested * Add lint test to test_msgs and fix linter issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to
This resolves CI failures introduced by #43.
CI: