Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change UUID type in action msgs #338

Merged
merged 3 commits into from
Dec 4, 2018
Merged

Change UUID type in action msgs #338

merged 3 commits into from
Dec 4, 2018

Conversation

apojomovsky
Copy link
Contributor

@apojomovsky apojomovsky commented Nov 21, 2018 •
edited by sloretz
Loading

This PR is part of a series of three that together close ros2/rcl_interfaces#49
EDIT: Depends on ros2/ros2#609

  • Make use of unique_identifier_msgs/uuid in rcl_action

connects to ros2/rcl_interfaces#49

@tfoote tfoote added the in progress Actively being worked on (Kanban column) label Nov 21, 2018
jacobperron
jacobperron approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending green CI

@apojomovsky
Copy link
Contributor Author

apojomovsky commented Nov 21, 2018 •
edited
Loading

Linux CI: Build Status

@sloretz sloretz mentioned this pull request Nov 27, 2018
Closed
24 tasks
@sloretz sloretz force-pushed the apojomovsky/change_uuid_type_in_action_msgs branch from 234f3eb to 519f755 Compare December 4, 2018 18:14
sloretz
sloretz approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI

@sloretz sloretz mentioned this pull request Dec 4, 2018
Merged
@sloretz sloretz merged commit b1c4d95 into master Dec 4, 2018
@sloretz sloretz deleted the apojomovsky/change_uuid_type_in_action_msgs branch December 4, 2018 19:05
@sloretz sloretz removed the in progress Actively being worked on (Kanban column) label Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

@jacobperron jacobperron jacobperron approved these changes

@hidmic hidmic Awaiting requested review from hidmic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change UUID type in action_msgs
4 participants
@apojomovsky @jacobperron @sloretz @tfoote