Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using a context manager for the python examples. #700

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

clalancette
Copy link
Contributor

@clalancette clalancette commented Jul 9, 2024

That way we can be sure to always clean up, but use less code doing so.

This is part of ros2/rclpy#1280

That way we can be sure to always clean up, but use less
code doing so.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette requested a review from sloretz July 9, 2024 18:34
@clalancette clalancette requested a review from ahcorde as a code owner July 9, 2024 18:34
@clalancette
Copy link
Contributor Author

clalancette commented Jul 9, 2024

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI!

@clalancette clalancette merged commit 82eb850 into rolling Jul 9, 2024
2 checks passed
@clalancette clalancette deleted the clalancette/rclpy-use-context-manager branch July 9, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants