Fix for building on Windows

[lilustga]

Undefine NO_ERROR when building on Windows to avoid collision with Windows.h

[aprotyas]

#349 should address this.

[lilustga]

@aprotyas Thanks for pointing that out. What is the path for this to end up in the Foxy branch?

Closing PR as #349 makes it obsolete

[aprotyas]

@aprotyas Thanks for pointing that out. What is the path for this to end up in the Foxy branch?

Usually I would say a backport, but I don't know if that's realizable for a deprecation. @clalancette is a backport of #349 possible? If not, this PR should probably just target the Foxy branch.

[clalancette]

Usually I would say a backport, but I don't know if that's realizable for a deprecation. @clalancette is a backport of #349 possible?

No, we can't backport that as-is because of the deprecation that we do not want to add to Foxy or Galactic. So I'd say we take this PR for Foxy and Galactic (remembering to do the push_macro/pop_macro stuff as done in #349).

[lilustga]

@clalancette that makes sense regarding not wanting to backport the the deprecation. I'll make PRs to Foxy and Galactic with the push_macro/pop_macro stuff.