Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MANUAL_BY_NODE liveliness API. #331

Merged

Conversation

fujitatomoya
Copy link
Collaborator

@fujitatomoya fujitatomoya commented Dec 24, 2022

related to ros2/rmw#227

this has been deprecated for more than 2 years, it should not be described in design.

we need to backport this to humble and foxy.

Signed-off-by: Tomoya.Fujita Tomoya.Fujita@sony.com

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

CC: @clalancette @ivanpauno

@clalancette
Copy link
Contributor

The design pages don't have per-distribution settings, so we just need to remove it this one place. I'll go ahead and merge it, thanks for the fix!

@clalancette clalancette merged commit 58d593a into ros2:gh-pages Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants