Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lock bundler version #210

Merged
merged 1 commit into from
Feb 8, 2019
Merged

lock bundler version #210

merged 1 commit into from
Feb 8, 2019

Conversation

dirk-thomas
Copy link
Member

Fix failing CI on the default branch.

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Feb 8, 2019
@dirk-thomas dirk-thomas self-assigned this Feb 8, 2019
@dirk-thomas dirk-thomas requested a review from wjwwood February 8, 2019 23:30
@nuclearsandwich
Copy link
Member

Ruby 2.1 has ended support. I think an optimal fix would be to try updating the ruby version to something more current.

@dirk-thomas
Copy link
Member Author

I think an optimal fix would be to try updating the ruby version to something more current.

Please feel free to do so in a follow up PR. This patch makes the CI pass with the same versions as before in order to continue merging other PRs.

Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to update to the latest version (or revisit GitHub's recommendations about this), but I guess this gets it going again.

@dirk-thomas dirk-thomas merged commit d47bf1b into gh-pages Feb 8, 2019
@dirk-thomas dirk-thomas deleted the bundler-version branch February 8, 2019 23:42
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Feb 8, 2019
@dirk-thomas
Copy link
Member Author

See follow up work in #211.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants