Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uint64 maps to unsigned long long #201

Merged
merged 2 commits into from
Nov 19, 2018
Merged

uint64 maps to unsigned long long #201

merged 2 commits into from
Nov 19, 2018

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Nov 19, 2018

Previously article mapped uint64 to unsigned long which is synonymous with unsigned int.

Previously article mapped uint64 to `unsigned long` which is synonymous with `unsigned int`.
@sloretz sloretz added the in review Waiting for review (Kanban column) label Nov 19, 2018
@sloretz sloretz requested a review from dirk-thomas November 19, 2018 16:04
@@ -99,7 +99,7 @@ the DDS-XTypes specification 1.2 defines it with 16-bit.
| int32 | int |
| uint32 | unsigned int |
| int64 | long |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should int64 be correspondingly long long

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dirk-thomas
Copy link
Member

The (u)int32 types should also be changed to (unsigned) long.

(u)int32 types are called `long` not `int` in IDL. Also `int64` is `long long` not `long`
Copy link
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rescinding my previous approval ;)

@sloretz
Copy link
Contributor Author

sloretz commented Nov 19, 2018

The (u)int32 types should also be changed to (unsigned) long.

3b9f617

@sloretz sloretz merged commit 97d5812 into gh-pages Nov 19, 2018
@sloretz sloretz deleted the sloretz-patch-1 branch November 19, 2018 16:42
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants