Fix pendulum demo regressions for rclcpp_library #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OMG this is the 42nd pull request in this repo! |
a7cb2c0 to
e947933
Compare
|
lgtm, should we do CI? |
e947933 to
9e3d0eb
Compare
9e3d0eb to
0eb22a5
Compare
wjwwood
added a commit
that referenced
this pull request
Nov 6, 2015
Fix pendulum demo regressions for rclcpp_library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea why leaving out the namespace in these files worked before.
@wjwwood
Connects to ros2/ros2#147