Add ros_distro parameter for CI jobs. #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter will be used to configure Windows builds with different sets of dependencies when building for specific ROS distributions.
dirk-thomas
approved these changes
May 13, 2020
nuclearsandwich
added a commit
that referenced
this pull request
May 20, 2020
Expands on the work from #450 to expose the CI parameter as a batch job argument. This is needed in order to install different Python wheels when running in the Windows debug configuration.
nuclearsandwich
added a commit
that referenced
this pull request
May 20, 2020
Expands on the work from #450 to expose the CI parameter as a batch job argument. This is needed in order to install different Python wheels when running in the Windows debug configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter will be used to configure Windows builds with different sets of dependencies when building for specific ROS distributions.
It doesn't do anything at the moment. It'll be used to switch Dockerfiles in subsequent PRs.