Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop running windows containers if they exist #395

Merged
merged 1 commit into from
Feb 29, 2020
Merged

Conversation

brawner
Copy link
Contributor

@brawner brawner commented Feb 28, 2020

If jenkins jobs are aborted by a user, then the docker container may not be stopped as a result. If these containers are already in a hung state then they'll continue running forever and won't release their hold on files in the ws directory. This will cause all subsequent jobs to fail.

This PR adds a docker stop command to stop all running containers before a new one is started.

Example failure
https://ci.ros2.org/job/ci_windows-container/244/

@nuclearsandwich nuclearsandwich merged commit 434af51 into master Feb 29, 2020
@nuclearsandwich nuclearsandwich deleted the docker_stop branch February 29, 2020 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants