place event handlers before #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this targets the colcon branch used in #132 |
dirk-thomas
approved these changes
Apr 20, 2018
dirk-thomas
pushed a commit
that referenced
this pull request
Apr 20, 2018
dirk-thomas
added a commit
that referenced
this pull request
Apr 21, 2018
* invoke colcon instead of ament_tools * remove obsolete escaping logic to deal with trailing double dashes * update package commands * fix --ros1-path position * test results * display console output for colcon tests as well (#150) * remove obsolete comment * add cmake args into existing argument if it exists * remove ament from (almost) everywhere * linter argument * run test-result twice, once with / once without --all * place event handlers before (#153) * use -j1 for bridge * determine colcon path on Windows * unify section naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty subjective as well but this allows me to add cmake args more easily (append at the end of the line rather than placing them in the middle), and I don't expect people to tweak event handlers parameters often