Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin flake8-builtins to sidestep regression #129

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Conversation

dhood
Copy link
Member

@dhood dhood commented Mar 19, 2018

ros2/build_farmer#99 has the context

CI up to rosidl_parser: Build Status (with 1.1.0 the test would not run properly)

Will revert when a fix is made upstream

@dhood dhood added the in review Waiting for review (Kanban column) label Mar 19, 2018
@dhood dhood self-assigned this Mar 19, 2018
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dhood dhood merged commit ae6bdae into master Mar 19, 2018
@dhood dhood deleted the flake8_builtins_pin branch March 19, 2018 19:07
@dhood dhood removed the in review Waiting for review (Kanban column) label Mar 19, 2018
dhood added a commit that referenced this pull request Mar 20, 2018
dhood added a commit that referenced this pull request Mar 20, 2018
dirk-thomas pushed a commit that referenced this pull request Mar 22, 2018
dirk-thomas pushed a commit that referenced this pull request Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants