Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visualization team and a release repository. #455

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Add visualization team and a release repository. #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions 00-members.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ locals {
local.vision_opencv_team,
local.vision_team,
local.visp_team,
local.visualization_team,
Copy link
Contributor

@clalancette clalancette Feb 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it is worth, I'm not a huge fan of calling this team visualization_team. There are a lot of repositories in https://github.com/ros-visualization, and the members of this team aren't necessarily the maintainers of all of these repositories.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clalancette any suggestion of another name would have been acceptable to me. In the absence of one, I'm going to merge as is but these team names don't propagate out of here so it's perfectly fine to change them later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that's fair. I can open a PR to rename this.

local.vrpn_team,
local.wep21_team,
local.xacro_team,
Expand Down
1 change: 1 addition & 0 deletions 00-repositories.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ locals {
local.vision_opencv_repositories,
local.vision_repositories,
local.visp_repositories,
local.visualization_repositories,
local.vrpn_repositories,
local.wep21_repositories,
local.xacro_repositories,
Expand Down
16 changes: 16 additions & 0 deletions visualization.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
locals {
visualization_team = [
"tonybaltovski",
]
visualization_repositories = [
"interactive_marker_twist_server-release",
]
}

module "visualization_team" {
source = "./modules/release_team"
team_name = "visualization"
members = local.visualization_team
repositories = local.visualization_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
Loading