Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointer typedefs for simple geometry and urdf::*_pointer_cast function #16

Merged
merged 4 commits into from
Oct 2, 2015

Conversation

scpeters
Copy link
Contributor

I had forgotten to include the Box, Cylinder, Mesh, and Sphere classes in the list of pointer typedefs in #13 . Since the lists were getting long, I followed @isucan 's suggestion and created a macro for defining the typedef's (13bf971). It was then easy to add the simple geometry classes (d37907c).

I also added urdf::dynamic_pointer_cast and several other pointer casting functions to further simplify migration. This is important because urdfdom and sdformat do pointer casts from Geometry to derived types:

@scpeters
Copy link
Contributor Author

I also removed an unused boost header include in b8be5cd

isucan added a commit that referenced this pull request Oct 2, 2015
Pointer typedefs for simple geometry and urdf::*_pointer_cast function
@isucan isucan merged commit 54d70bf into ros:master Oct 2, 2015
@scpeters scpeters deleted the geometry_typedefs branch October 2, 2015 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants