Pointer typedefs for simple geometry and urdf::*_pointer_cast function #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had forgotten to include the
Box
,Cylinder
,Mesh
, andSphere
classes in the list of pointer typedefs in #13 . Since the lists were getting long, I followed @isucan 's suggestion and created a macro for defining the typedef's (13bf971). It was then easy to add the simple geometry classes (d37907c).I also added
urdf::dynamic_pointer_cast
and several other pointer casting functions to further simplify migration. This is important because urdfdom and sdformat do pointer casts fromGeometry
to derived types: