Switch all stod callers in urdfdom to use a helper #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
It is not locale-safe, so switch to using the strToDouble utility from urdfdom_headers instead. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
(the Travis CI will fail until ros/urdfdom_headers#42 is merged) |
|
All right, now that the other PRs are merged, I think we can also review this one. I'm going to close it out and re-open to re-trigger Travis. |
scpeters
approved these changes
Feb 21, 2018
|
Great, thanks. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The short of it is that
str::stodis not locale-safe, so instead we use the stream operator imbued as "classic" (C) locale. This PR depends on ros/urdfdom_headers#42, so it should not be merged until that one is merged/released. While I was at it, I added a bunch of tests just to ensure we are doing the right thing in various places, mostly surrounding the conversion of strings to doubles.