Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Galactic] Backport github actions CI #11

Merged
merged 3 commits into from
Jun 8, 2022
Merged

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Jun 3, 2022

@chapulina mind taking a look?

Ubuntu Focal with ROS Galactic: testing Gazebo Citadel, Edifice (only because ROS Galactic pairs with it in REP 2000), and Fortress.

sloretz and others added 2 commits June 3, 2022 16:09
* CI for Focal and Jammy

Signed-off-by: Shane Loretz <sloretz@openrobotics.org>

* Only run on pull_request updates

Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
@chapulina
Copy link
Contributor

It looks like all jobs are using Citadel, because there's no logic to choose different SDF versions. Let me rebase #8 onto this to see if I can get a different version on each job.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The only change I made to this file on #8 was s/gazebo/gz - I know I was the one who originally used "gazebo", sorry about that.

Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
@sloretz
Copy link
Contributor Author

sloretz commented Jun 8, 2022

LGTM! The only change I made to this file on #8 was s/gazebo/gz

I pulled the change from your branch to this one. I'll retarget #8 so I don't accidentally close it this time when I merge (hopefully that doesn't do anything worse 🤞)

@sloretz sloretz merged commit 28565be into galactic Jun 8, 2022
@sloretz sloretz deleted the sloretz__ci_galactic branch June 8, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants