-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openhrp3: 3.1.9-1 in 'kinetic/distribution.yaml' [bloom] #14091
Conversation
hope this closes fkanehiro/openhrp3#123 |
The sourcedeb job has failed to build: http://build.ros.org/view/Kbin_uxhf_uXhf/job/Ksrc_uX__openhrp3__ubuntu_xenial__source/15/console#console-section-11 @tfoote This is one of the first jobs with a deb inc which uses ros-infrastructure/ros_buildfarm#374 to download the existing tarball. Can you please double check that the failure is not related to that change (and advise @k-okada what he might have to do). |
Sorry this is my fault, I'll fix soon
2017年3月7日(火) 2:16 Dirk Thomas <notifications@github.com>:
The sourcedeb job has failed to build:
http://build.ros.org/view/Kbin_uxhf_uXhf/job/Ksrc_uX__openhrp3__ubuntu_xenial__source/15/console#console-section-11
@tfoote <https://github.com/tfoote> This is one of the first jobs with a
deb inc which uses ros-infrastructure/ros_buildfarm#374
<ros-infrastructure/ros_buildfarm#374> to
download the existing tarball. Can you please double check that the failure
is not related to that change (and advise @k-okada
<https://github.com/k-okada> what he might have to do).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14091 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAeG3DyVZGJJvUwbcp8ZcWQ3ASTEedaiks5rjD89gaJpZM4MUOw1>
.
--
--
◉ Kei Okada
|
@k-okada this isn't your fault I'm looking into fixing our sourcedeb generation to add support for this case. |
@tfoote not sure what's happened exactly, but I think at least I did something wrong, If I run
|
@k-okada Can you please explain what you have changed that might fix the problem? I would argue that the sourcedeb job for your previous deb inc should pass no matter what. It looks like a regression from ros-infrastructure/ros_buildfarm#374. |
We had problem on openhrp3 (3.1.9) build as reported in
fkanehiro/openhrp3#123, which because of missing
header file (stdint.h), since I have no control over openhrp3 repository
and they have different version convention, I intend to patched in
release/kinetic/openhrp3 branch of openhrp3-release as
tork-a/openhrp3-release@8dcbd48,
and re-release by 'git-bloom-release' command.
This should work, but seems I did something wrong, may be patched in wrong
branch? Sorry that my memory is not clear ....
…--
◉ Kei Okada
2017-03-08 1:15 GMT+09:00 Dirk Thomas <notifications@github.com>:
@k-okada <https://github.com/k-okada> Can you please explain what you
have changed that might fix the problem? I would argue that the sourcedeb
job for your previous deb inc should pass no matter what. It looks like a
regression from ros-infrastructure/ros_buildfarm#374
<ros-infrastructure/ros_buildfarm#374>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14091 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAeG3KpGGmXQEG7-VdiJBLPsfWaff28aks5rjYKxgaJpZM4MUOw1>
.
|
p.s. I do not fully understand your problem on sourcedeb job problem, It
might be a one of causes, but I am pretty sure that I had a problem on our
side too.
…--
◉ Kei Okada
2017-03-08 9:20 GMT+09:00 Kei Okada <k-okada@jsk.t.u-tokyo.ac.jp>:
We had problem on openhrp3 (3.1.9) build as reported in
fkanehiro/openhrp3#123, which because of
missing header file (stdint.h), since I have no control over openhrp3
repository and they have different version convention, I intend to patched
in release/kinetic/openhrp3 branch of openhrp3-release as
https://github.com/tork-a/openhrp3-release/commit/
8dcbd48330d2684e21cf744d6562ccafd6fd8f49, and re-release by
'git-bloom-release' command.
This should work, but seems I did something wrong, may be patched in wrong
branch? Sorry that my memory is not clear ....
--
◉ Kei Okada
2017-03-08 1:15 GMT+09:00 Dirk Thomas ***@***.***>:
> @k-okada <https://github.com/k-okada> Can you please explain what you
> have changed that might fix the problem? I would argue that the sourcedeb
> job for your previous deb inc should pass no matter what. It looks like a
> regression from ros-infrastructure/ros_buildfarm#374
> <ros-infrastructure/ros_buildfarm#374>.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#14091 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AAeG3KpGGmXQEG7-VdiJBLPsfWaff28aks5rjYKxgaJpZM4MUOw1>
> .
>
|
@k-okada Thanks for the info. If for any reason the code of your package fails to build that would happen in the binary job. I am pretty sure that the source job is failing due to a regression in the buildfarm itself. Once that has been addressed and the source job passes again we will happily merge the pending PR to get the latest release of your package built. |
@dirk-thomas thanks for explanation and found everything working find -> http://build.ros.org/view/Kbin_uxhf_uXhf/job/Kbin_uxhf_uXhf__openhrp3__ubuntu_xenial_armhf__binary/47/ |
No problem, that was kind of tricky and not obvious. Glad it works now. 🎉 |
Increasing version of package(s) in repository
openhrp3
to3.1.9-1
:kinetic/distribution.yaml
0.5.23
3.1.9-0
openhrp3