rosbag_snapshot independent package #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a great idea! Do you have the authority to just get this into the |
|
@paulbovbel I just got word from Tully that once I have the repo somewhere else, they'll put it in the ros namespace too. ros/ros_comm#1414 (comment) Anything you want to update first? |
|
No, we've been using this code for ages, so LGTM! |
paulbovbel
approved these changes
Apr 17, 2020
tappan-at-git
approved these changes
Apr 17, 2020
MikHut
pushed a commit
to SAGARobotics/rosbag_snapshot
that referenced
this pull request
Oct 23, 2023
…tched-messages RST-4799 Retain latest latched messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to remove our fork of ros_comm and close ros/ros_comm#1414 I've converted the PR above to an independent package, which turns out to be easier than I expected. I already committed the raw files copied from
rosbaginto this repo and renamed many of the things to the new package names. This PR just does some standard cleanup and linting. Open to additional suggestions for improvements.I got permission from the PR's author to release and maintain this on our side of things, although this is a private repo for now.