fix default value for non-primitive fixed-size arrays #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return '[' + def_val + '] * ' + str(array_len) | ||
| if base_type in [ | ||
| 'byte', 'int8', 'int16', 'int32', 'int64', 'uint16', 'uint32', | ||
| 'uint64', 'float32', 'float64', 'string', 'bool' |
There was a problem hiding this comment.
looking at http://wiki.ros.org/msg, looks like byte should be called uint8 here.
Or to match how it's defined above in the same file we should add both char and uint8 to this list for completeness
There was a problem hiding this comment.
This code needs to handle all possible types. Therefore I think it needs to also check for byte.
It does not need to consider char and uint8 though since those are already handled in the if block above.
There was a problem hiding this comment.
oh sorry I missed that it was the same conditional block. All good then
|
Except nitpick comment looks good to me |
wjwwood
approved these changes
Feb 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression of #64 as reported in #64 (comment)
@ros/ros_team Please review.