enable int/long values for list of time/duration (fix #13) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else: | ||
| raise MessageException("Cannot create time values of type [%s]"%(type(inner_msg))) | ||
| else: | ||
| _fill_message_args(inner_msg, el, prefix) |
There was a problem hiding this comment.
This is unrelated to this patch but I am worried about the arguments in this line. It seems that the keys argument is missing. Any thoughts?
|
The code looks ok to me, but I can't see why the keys variable isn't used either. I don't really have a good handle on the context of this code. |
dirk-thomas
added a commit
that referenced
this pull request
Aug 16, 2013
enable int/long values for list of time/duration (fix #13)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tfoote @wjwwood Please review.