Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[noetic port] Use setuptools instead of distutils #22

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Mar 12, 2020

This pull request is to apply the noetic migration by this ROS Wiki: http://wiki.ros.org/noetic/Migration

P.S. Updating it to setuptools helps packaging system such like conda packages passing --single-version-externally-managed to avoid Python egg generation.

@seanyen
Copy link
Contributor Author

seanyen commented Mar 12, 2020

@sloretz @dirk-thomas @tfoote This is ready for review and merge. Thanks!

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

@tfoote tfoote merged commit fe974f2 into ros:master Mar 12, 2020
tfoote pushed a commit that referenced this pull request Mar 12, 2020
In parallel to  (#22)

Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@tfoote tfoote mentioned this pull request Mar 12, 2020
tfoote added a commit that referenced this pull request Mar 20, 2020
In parallel to  (#22)

Signed-off-by: Tully Foote <tfoote@osrfoundation.org>

Co-authored-by: Sean Yen <seanyen@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants