Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable shiboken when version is detected which would segfault (fix #728) #729

Merged
merged 1 commit into from
Feb 26, 2014
Merged

Disable shiboken when version is detected which would segfault (fix #728) #729

merged 1 commit into from
Feb 26, 2014

Conversation

bchretien
Copy link
Contributor

Fix #728

@wjwwood
Copy link
Member

wjwwood commented Feb 25, 2014

@dirk-thomas can you review this also? It seems to be up your alley.

@wjwwood wjwwood added this to the 1.10.12 - Hydro milestone Feb 25, 2014
dirk-thomas
dirk-thomas reviewed Feb 26, 2014
View reviewed changes
src/python_bindings/shiboken/CMakeLists.txt
set(rviz_BINDINGS "${rviz_BINDINGS}" PARENT_SCOPE)
if(Shiboken_VERSION VERSION_GREATER "1.1.1")
# shiboken 1.1.2 and higher will segfault until https://bugreports.qt-project.org/browse/PYSIDE-218 is fixed
message(WARNING "Shiboken version ${Shiboken_VERSION} would segfault when trying to process qt_gui_cpp (see https://bugreports.qt-project.org/browse/PYSIDE-218). Therefore shiboken bindings are being skipped.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-n-paste. Please replace qt_gui_cpp with something rviz specific.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch! The curse of the 1AM commit... Amended and pushed.

@wjwwood
Copy link
Member

wjwwood commented Feb 26, 2014

Ok, looks good to me.

wjwwood added a commit that referenced this pull request Feb 26, 2014
@wjwwood
Merge pull request #729 from bchretien/hydro-devel
e2a21f0 
Disable shiboken when version is detected which would segfault (fix #728)
@wjwwood wjwwood merged commit e2a21f0 into ros-visualization:hydro-devel Feb 26, 2014
@bchretien
Copy link
Contributor Author

Great, thanks!

130s pushed a commit to 130s/rviz that referenced this pull request Aug 21, 2024
@wolfv @ahcorde
Fix for ogre failing when material already exists (ros-visualization#729
617cbc1 
)

* Fix for ogre failing when material already exists

* Update rviz_rendering/src/rviz_rendering/material_manager.cpp

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

* fix uncrustify

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.12 - Hydro
Development

Successfully merging this pull request may close these issues.
3 participants
@bchretien @wjwwood @dirk-thomas