Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup SplitterHandle #1766

Merged
merged 5 commits into from
Aug 12, 2022
Merged

Fixup SplitterHandle #1766

merged 5 commits into from
Aug 12, 2022

Conversation

rhaschke
Copy link
Contributor

Fixup for #1760

All issues essentially originate from horizontal scrolling. To avoid this, we need to:

  • setStretchLastSection(false)
  • decrease the shrinking column first before increasing the other one
  • Consider Resize events of the viewport, not the QTreeView itself
  • In case horizontal scrolling still occurs, have the scrollbar visible at least

@rhaschke
Listen to resize events of parent's viewport only
1b85efa
@rhaschke
Resize last column to available viewport width
a791914
@rhaschke
Correctly limit column widths
026c383 
Both columns need to be limited in width such that
horizontal scrolling never happens.
That is, both columns must respect minimumSectionSize().
Value column additionally needs to accomodate scrollbar if needed.
@rhaschke
Don't hide horizontal scrollbar
117d624 
In case the scroll area is shifted (which should not happen),
the scrollbar will be helpful to get back to the origin.
@rhaschke
Allow zero column widths
630b246
@rhaschke rhaschke merged commit c1046a1 into ros-visualization:melodic-devel Aug 12, 2022
@rhaschke rhaschke deleted the fix-1760 branch August 12, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rhaschke