Fixup assimp mesh loading #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fixup of 7085a14. Obviously, assimp's root node is only sometimes, but not always applying a rotation to y-up orientation. This fixup, drops the rotation part of the root transform, but keeps the scaling (and position offset).
|
I checked this PR, and this PR solves #1688 Before: rviz After: this PR |
|
You might want to cross check with the ogre assimp plugin here just to be sure: https://github.com/OGRECave/ogre/blob/ff55ef7b272fa0fb5be935ac41af67f5d6e15bf4/PlugIns/Assimp/src/AssimpLoader.cpp#L377 |
simonschmeisser
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fixup of #1685, fixing a regression revealed in #1688.
Looks like assimp's root node is only sometimes, but not always applying a rotation to y-up orientation.
This fixup, drops the rotation part of the root transform, but keeps the scaling (and position offset).