Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature to display pose markers(axes or arrow) #1016

Merged
merged 1 commit into from
Oct 17, 2016
Merged

Add a feature to display pose markers(axes or arrow) #1016

merged 1 commit into from
Oct 17, 2016

Conversation

longjie
Copy link

@longjie longjie commented May 29, 2016

Hi,
This PR is for adding pose markers (axes or arrow) to Path display.
I personally wanted this feature to visualize the planned path including the pose of each waypoint.
Please merge if anyone needs this and the patch is acceptable.
Thank you,

- it would be handy to see mobile robot's path and its orientation
- using rviz::Axes and rviz::Arrow
@NikolausDemmel
Copy link
Contributor

I didn't look at the patch, but just wanted to say that this addition would be very useful to us. If fact, we are using a visualization node together with the Marker Display to achieve something similar for Path messages. Having this ability directly in the Path Disaply would be much nicer. So thanks for the contribution!

@wjwwood wjwwood added this to the untargeted milestone Oct 17, 2016
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wjwwood
Copy link
Member

wjwwood commented Oct 17, 2016

I tried it out locally and it seems to work as advertised. Thanks for the contribution!

@wjwwood wjwwood merged commit e75a909 into ros-visualization:indigo-devel Oct 17, 2016
@longjie longjie deleted the add-pose-marker-to-path-display branch November 28, 2016 07:15
@hiddewie
Copy link
Contributor

Great! Thanks @NikolausDemmel and @wjwwood for the quick feedback!

130s pushed a commit to 130s/rviz that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants