Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for normalized quaternion before passing to Ogre #1142

Closed
dhood opened this issue Aug 17, 2017 · 2 comments
Closed

Check for normalized quaternion before passing to Ogre #1142

dhood opened this issue Aug 17, 2017 · 2 comments
Labels
enhancement help wanted

Comments

@dhood
Copy link
Contributor

dhood commented Aug 17, 2017

As reported in #1137, crashes occur when non-normalized quaternions are passed through to Ogre.

A fix for one instance was implemented in #1139 but there are other parts in the codebase that are susceptible. Ideally the logic added in that PR would be factored out and reused in other places (as is done with validate_floats.h).

This would be a good task for someone new to the codebase if anyone is interested
@dhood dhood added this to the untargeted milestone Aug 17, 2017
This was referenced Aug 17, 2017
Merged
Closed
@StefanFabian
Copy link
Contributor

StefanFabian commented Oct 18, 2017 •
edited
Loading

I've implemented this but I have a question regarding the license in the new validate_quaternions.h.
Should I keep "Willow Garage, Inc" or replace it with my name?
Apart from their existence, I don't really know much about licenses.

Edit: I went with keeping it. I hope that's correct.

@StefanFabian StefanFabian mentioned this issue Oct 22, 2017
Merged
StefanFabian added a commit to StefanFabian/rviz that referenced this issue Nov 21, 2017
@StefanFabian
Updated copyright
3905e15 
Apparently keeping "Willow Garage, Inc" (ros-visualization#1142) was not the right thing (ros-visualization#1113).
dhood pushed a commit that referenced this issue Dec 11, 2017
@StefanFabian @dhood
Added checks for invalid quaternions. (#1167)
b329145 
* Added check for invalid quaternions.

* Updated copyright

Apparently keeping "Willow Garage, Inc" (#1142) was not the right thing (#1113).

* Relaxed tolerance as discussed in #1167
@dhood
Copy link
Contributor Author

dhood commented Dec 12, 2017

closed by #1167

@dhood dhood closed this as completed Dec 12, 2017
@yk-fujii yk-fujii mentioned this issue Mar 14, 2023
Closed
130s pushed a commit to 130s/rviz that referenced this issue Aug 21, 2024
@mergify @ahcorde
Added Cache to camera display for TimeExact (ros-visualization#1138) (r…
ced2d7a 
…os-visualization#1142)

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit fdf195771a948d510768ec2ccb08b0c78fdc2b14)

Co-authored-by: Alejandro Hernández Cordero <alejandro@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StefanFabian @dhood