Skip to content

Commit

Permalink
Call propertyHiddenChanged synchronously (#1795)
Browse files Browse the repository at this point in the history
Otherwise, using queued signal-slot connection, the passed Property* might no longer exist anymore, when the slot is processed.
  • Loading branch information
simonschmeisser authored May 18, 2023
1 parent 10cb16e commit fb5348f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/rviz/properties/property_tree_widget.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ void PropertyTreeWidget::setModel(PropertyTreeModel* model)
m->deleteLater();

connect(model_, SIGNAL(propertyHiddenChanged(const Property*)), this,
SLOT(propertyHiddenChanged(const Property*)), Qt::QueuedConnection);
SLOT(propertyHiddenChanged(const Property*)));
connect(model_, SIGNAL(expand(const QModelIndex&)), this, SLOT(expand(const QModelIndex&)));
connect(model_, SIGNAL(collapse(const QModelIndex&)), this, SLOT(collapse(const QModelIndex&)));

Expand Down

0 comments on commit fb5348f

Please sign in to comment.